Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LunaMedia Adapter #5110

Merged
merged 4 commits into from
Apr 23, 2020
Merged

LunaMedia Adapter #5110

merged 4 commits into from
Apr 23, 2020

Conversation

trchandraprakash
Copy link
Contributor

@trchandraprakash trchandraprakash commented Apr 11, 2020 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Chandra Prakash and others added 3 commits March 16, 2019 23:41
Update Bidder Code
d2db964
@trchandraprakash
Merge pull request #1 from prebid/master
3b5482a 
update prebid.js code base from fork
LunaMedia Adapater
dd5accd 
LunaMedia Adapater
@trchandraprakash
Copy link
Contributor Author

Hi Guys,

Can you please let me know if all good here and when adapter will get merged.

Thanks & Regards
Chandra Prakash

@harpere harpere assigned mike-chowla and unassigned mike-chowla Apr 14, 2020
@harpere harpere requested review from akovalnj and removed request for mike-chowla April 14, 2020 20:44
@trchandraprakash
Copy link
Contributor Author

Hi Please find docs below
prebid/prebid.github.io#1925

@trchandraprakash
Copy link
Contributor Author

Hi Guys, Can you please let me know if all good here and when adapter will get available for client.

@trchandraprakash
Copy link
Contributor Author

Hi Guys, Our clients eagerly waiting for adapter, can you please let me know if anything else pending from my side.

akovalnj
akovalnj suggested changes Apr 20, 2020
View reviewed changes
Copy link

@akovalnj akovalnj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not get the test parameters to return an ad. All adapters are required to contain valid test parameters. Please update the markdown file accordingly.

Also, please use mediatypes instead of adunit sizes. Documentation can be found here: http://prebid.org/dev-docs/publisher-api-reference.html#adUnit-banner

akovalnj
akovalnj suggested changes Apr 21, 2020
View reviewed changes
Copy link

@akovalnj akovalnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameters are still getting a 204 when I try them from the test page. IT should be returning a 200 along with an ad.

@trchandraprakash
Copy link
Contributor Author

trchandraprakash commented Apr 21, 2020 •
edited
Loading

I modifying my earlier comment since, i am able to see ads.
Try refreshing 5 - 10 times you should see ads.
I am using this configuration in hello_world.html.
Same goes for 320x50 request.

    var adUnits = [{
        code: 'div-gpt-ad-1460505748561-0',
        mediaTypes: {
            banner: {
                sizes: [[320, 250]]
            }
        },
        // Replace this object to test a new Adapter!
        bids: [{
            bidder: 'lunamedia',
            params: {
                pubid: '121ab139faf7ac67428a23f1d0a9a71b',
                placement: 12345
            }
        }]
    }];

@akovalnj
Copy link

Still getting 204s for both banner and video event though I tried 20 times.

There were some fixes checked in recently that may solve your build issue. Please do another checkout and try the build again.

@akovalnj
Copy link

The 204 issue was on my end. I needed to use a different IP alias other than localhost. Consistenly getting 200s now.

But noticed one other thing. There is a function to get the referrer when it seems that you could just get the value from bidderRequest.refererInfo.referer. Do you need that extra layer?

@trchandraprakash
Copy link
Contributor Author

Yes, lets keep that function for now.

@akovalnj akovalnj merged commit b5aa77a into prebid:master Apr 23, 2020
@bjorn-lw bjorn-lw mentioned this pull request May 6, 2020
Closed
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@trchandraprakash @iggyfisk
LunaMedia Adapter (prebid#5110)
d2498d3 
* Update Bidder Code

* LunaMedia Adapater

LunaMedia Adapater

* Updated LunamediaBidAdapter.md test params and valid pub code for testing

Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akovalnj akovalnj akovalnj approved these changes

Assignees

@akovalnj akovalnj

Labels
needs docs needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trchandraprakash @akovalnj @harpere @mike-chowla